Merge lp:~sil2100/address-book-service/packaging_review into lp:address-book-service

Proposed by Łukasz Zemczak
Status: Rejected
Rejected by: Renato Araujo Oliveira Filho
Proposed branch: lp:~sil2100/address-book-service/packaging_review
Merge into: lp:address-book-service
Diff against target: 57 lines (+18/-7)
2 files modified
debian/changelog (+9/-2)
debian/control (+9/-5)
To merge this branch: bzr merge lp:~sil2100/address-book-service/packaging_review
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+167812@code.launchpad.net

Commit message

Rename source package to address-book-service. Modifications related to compliance with our packaging standards

Description of the change

Packaging review. Modifications related to compliance with our packaging standards. Rename source package to address-book-service, since it makes no sense to have a different name than the LP project name.

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Perhaps the binary should be renamed too?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

this should be renamed:

52 +Depends: galera-contact-service (= ${source:Version}),

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> Perhaps the binary should be renamed too?

I will rename the binary in a new MR.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

you will need to rename the ".install" file too.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-06-05 21:22:37 +0000
3+++ debian/changelog 2013-06-06 17:02:25 +0000
4@@ -1,5 +1,12 @@
5-galera-contact-service (0.1.0) saucy; urgency=low
6+address-book-service (0.1.0-0ubuntu1) UNRELEASED; urgency=low
7
8+ [ Renato Araujo Oliveira Filho ]
9 * Initial release.
10
11- -- Renato Araujo Oliveira Filho <renato@canonical.com> Wed, 05 Jun 2013 15:13:34 -0300
12+ [ Łukasz 'sil2100' Zemczak ]
13+ * debian/control:
14+ - Modifications related to compliance with our packaging standards
15+ * Change source package name to address-book-service
16+ * Automatic snapshot from revision 23 (bootstrap)
17+
18+ -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Thu, 06 Jun 2013 18:48:25 +0200
19
20=== modified file 'debian/control'
21--- debian/control 2013-06-05 21:22:37 +0000
22+++ debian/control 2013-06-06 17:02:25 +0000
23@@ -1,16 +1,20 @@
24-Source: galera-contact-service
25+Source: address-book-service
26 Section: utils
27 Priority: optional
28 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
29 Build-Depends: cmake (>= 2.8.9),
30 debhelper (>= 9),
31+ libfolks-dev,
32 qt5-default,
33 qt5-qmake,
34 qtbase5-dev,
35 qtpim5-dev,
36- libfolks-dev,
37 Standards-Version: 3.9.4
38-Vcs-Bzr: lp:~phablet-team/address-book-service/trunk
39+Homepage: https://launchpad.net/address-book-service
40+# If you aren't a member of ~phablet-team but need to upload packaging changes,
41+# just go ahead. ~phablet-team will notice and sync up the code again.
42+Vcs-Bzr: https://code.launchpad.net/~phablet-team/address-book-service/trunk
43+Vcs-Browser: http://bazaar.launchpad.net/~phablet-team/address-book-service/trunk/files
44
45 Package: galera-contact-service
46 Architecture: any
47@@ -21,8 +25,8 @@
48
49 Package: qtcontact5-galera
50 Architecture: any
51-Depends: ${misc:Depends},
52+Depends: galera-contact-service (= ${source:Version}),
53+ ${misc:Depends},
54 ${shlibs:Depends},
55- galera-contact-service (= ${source:Version}),
56 Description: QtContacts backend for galera contact service.
57 A QContactEngine implementation using galera contact service.

Subscribers

People subscribed via source and target branches