Code review comment for lp:~sil/ubuntuone-client/no-unknown-login-error

Revision history for this message
Stuart Langridge (sil) wrote :

> 94 + opener = FancyURLOpenerWithRedirectedPOST()
> 95 + fp = opener.open(oauth_request.http_url,
> oauth_request.to_postdata())
> 96 + data = fp.read()
>
> It would be great if this block of code could be in a try:/except: clause.
>
> except IOError, e:
> if self.callback_error:
> callback_error(str(e))
> else:
> raise e

Done.

« Back to merge proposal