Code review comment for lp:~sil/ubuntu-keyboard/numbers-on-top-row

Revision history for this message
Thomas Moenicke (thomas-moenicke) wrote :

Thanks for your MR! Did not get any feedback yet from design, anyways:

- for the numbers in the first row, I am basically fine with that but we would need that for all languages to be consistent
- refactoring: basically the right step of abstraction from the engineering point of view, however we wanted to keep a good overview of the entire layout at once, therefor I prefer to keep it as it is. The amount of maintenance for the current setup should be low, as it is very simple to do in QML.

« Back to merge proposal