Merge lp:~sil/rhythmbox-ubuntuone/fix-mp3-install into lp:~sil/rhythmbox-ubuntuone/trunk

Proposed by Stuart Langridge
Status: Merged
Merged at revision: not available
Proposed branch: lp:~sil/rhythmbox-ubuntuone/fix-mp3-install
Merge into: lp:~sil/rhythmbox-ubuntuone/trunk
Diff against target: 42 lines (+4/-7)
1 file modified
umusicstore/__init__.py (+4/-7)
To merge this branch: bzr merge lp:~sil/rhythmbox-ubuntuone/fix-mp3-install
Reviewer Review Type Date Requested Status
Guillermo Gonzalez (community) Approve
Stuart Langridge Pending
Review via email: mp+20458@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stuart Langridge (sil) wrote :

Fix the mp3-codec installer, which I broke, doh.

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

works

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'umusicstore/__init__.py'
--- umusicstore/__init__.py 2010-02-22 16:23:36 +0000
+++ umusicstore/__init__.py 2010-03-02 16:17:15 +0000
@@ -150,9 +150,6 @@
150 """Source startup."""150 """Source startup."""
151 if self.__activated: return151 if self.__activated: return
152 self.__activated = True152 self.__activated = True
153 self.body = gtk.EventBox()
154 self.pack_start(self.body)
155 self.body.show_all()
156 self.test_can_play_mp3()153 self.test_can_play_mp3()
157 rb.Source.do_impl_activate (self)154 rb.Source.do_impl_activate (self)
158155
@@ -210,7 +207,7 @@
210 self.install_vbox.pack_start(self.install_hbtn, expand=False)207 self.install_vbox.pack_start(self.install_hbtn, expand=False)
211 self.install_box.add(self.install_vbox)208 self.install_box.add(self.install_vbox)
212 self.install_box.show_all()209 self.install_box.show_all()
213 self.body.add_with_viewport(self.install_box)210 self.add(self.install_box)
214211
215 def _start_mp3_install(self, btn):212 def _start_mp3_install(self, btn):
216 ac = aptdaemon.client.AptClient()213 ac = aptdaemon.client.AptClient()
@@ -233,7 +230,7 @@
233 def _finished(self, trans, exit_code):230 def _finished(self, trans, exit_code):
234 """Aptdaemon package installation finished; show music store."""231 """Aptdaemon package installation finished; show music store."""
235 if exit_code == 0:232 if exit_code == 0:
236 self.body.remove(self.install_box.get_parent())233 self.remove(self.install_box)
237 gst.update_registry()234 gst.update_registry()
238 self.add_music_store_widget()235 self.add_music_store_widget()
239 else:236 else:
@@ -255,8 +252,8 @@
255 def add_music_store_widget(self):252 def add_music_store_widget(self):
256 """Display the music store widget in Rhythmbox."""253 """Display the music store widget in Rhythmbox."""
257 self.browser = U1MusicStore()254 self.browser = U1MusicStore()
258 self.body.add(self.browser)255 self.add(self.browser)
259 self.body.show_all()256 self.show_all()
260 self.browser.set_no_show_all(True)257 self.browser.set_no_show_all(True)
261 self.browser.set_property("visible", True)258 self.browser.set_property("visible", True)
262 self.browser.connect("preview-mp3", self.re_emit_preview)259 self.browser.connect("preview-mp3", self.re_emit_preview)

Subscribers

People subscribed via source and target branches

to all changes: