Code review comment for lp:~sil/desktopcouch/dc-load-design-docs

Revision history for this message
dobey (dobey) wrote :

> > You need to add the following to MANIFEST.in:
> >
> > recursive-include contrib *.py
>
> I am told that I don't need to; the mocker is there for the test suite and
> doesn't need to be in the final package.

Who told you that? It's true that contrib/ doesn't need to be in the binary packages in debian/ubuntu/redhat/whatever, but it does need to be in the source tarball, so that the tests are runnable. We shouldn't ship tarballs that fail to run the tests, because we decided not to put a contrib python file in there.

« Back to merge proposal