Code review comment for lp:~sil/component-store/community-components

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Things that needs fixing,

1. Remove legacy ucs.sh script

2. Remove support for qmake and cmake projects. What we have currently has 2 main issues which are, "installing to the wrong directory" and "invalid CMakeLists.txt". The app project structure is not constant and this is more prevalent in cmake projects where qml code usually goes into app/* and c++ components go into backend/* or src/*. Adding ubuntu_component_store to the root folder might not be appreciated by developers.

for now just adding the necessary components into a folder called ubuntu_component_store and requiring app developers to do the rest of the bootstrapping would suffice IMO. We can build on top of that once we get help from the community and the SDK devs.

3. Merge lp:~nik90/component-store/fix-debian-packaging into this MP. Although before doing that please check the debian/control file to see if it has all the necessary dependency for ucs. If a dependency is missing, please let me know and I will add it.

After this MP is merged I will update the online docs and release a update in the PPA.

« Back to merge proposal