Code review comment for lp:~sidnei/juju-core/sort-by-cost-lowest-fallback

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

I think this is a good change, but please can you live test it on
canonistack at least? LGTM otherwise.

https://codereview.appspot.com/12569044/diff/1/environs/instances/instancetype_test.go
File environs/instances/instancetype_test.go (right):

https://codereview.appspot.com/12569044/diff/1/environs/instances/instancetype_test.go#newcode10
environs/instances/instancetype_test.go:10:
"launchpad.net/juju-core/constraints"
Blank line after gocheck please. And while you're at it, could you do:

gc "launchpad.net/gocheck"

Up there and change it below - it's a pretty small file, so it shouldn't
incur to many changes.

https://codereview.appspot.com/12569044/diff/1/environs/instances/instancetype_test.go#newcode237
environs/instances/instancetype_test.go:237: var byCostTest = []struct {
s/byCostTest/byCostTests/ I think

https://codereview.appspot.com/12569044/diff/1/environs/instances/instancetype_test.go#newcode238
environs/instances/instancetype_test.go:238: info string
It's more typical to call this field "about" in the table.

https://codereview.appspot.com/12569044/

« Back to merge proposal