Code review comment for lp:~sidnei/juju-core/lxc-mirror

Revision history for this message
Scott Moser (smoser) wrote :

so i think this is reasonable.
the only comments (that I think Sidnei is aware of) is that https_proxy set via runcmnd will be too late to affect 'apt-get installs' from cloud-config.

they should work fine for subsequent juju charm installs. though.

the principle seems sound here.

review: Approve

« Back to merge proposal