LGTM with a couple of trivials. Thanks a lot.
https://codereview.appspot.com/12143043/diff/22001/container/lxc/lxc_test.go File container/lxc/lxc_test.go (right):
https://codereview.appspot.com/12143043/diff/22001/container/lxc/lxc_test.go#newcode128 container/lxc/lxc_test.go:128: "ifconfig"})
We'd usually put the }) on a new line here, so each string gets its own line.
https://codereview.appspot.com/12143043/diff/22001/utils/apt.go File utils/apt.go (right):
https://codereview.appspot.com/12143043/diff/22001/utils/apt.go#newcode61 utils/apt.go:61: "Acquire::ftp::Proxy"}
newline before } please
https://codereview.appspot.com/12143043/
« Back to merge proposal
LGTM with a couple of trivials.
Thanks a lot.
https:/ /codereview. appspot. com/12143043/ diff/22001/ container/ lxc/lxc_ test.go lxc/lxc_ test.go (right):
File container/
https:/ /codereview. appspot. com/12143043/ diff/22001/ container/ lxc/lxc_ test.go# newcode128 lxc/lxc_ test.go: 128: "ifconfig"})
container/
We'd usually put the }) on a new line here, so each string gets its own
line.
https:/ /codereview. appspot. com/12143043/ diff/22001/ utils/apt. go
File utils/apt.go (right):
https:/ /codereview. appspot. com/12143043/ diff/22001/ utils/apt. go#newcode61 :ftp::Proxy" }
utils/apt.go:61: "Acquire:
newline before } please
https:/ /codereview. appspot. com/12143043/