Code review comment for lp:~sidnei/juju-core/lxc-mirror

Revision history for this message
Sidnei da Silva (sidnei) wrote :

Reviewers: mp+177737_code.launchpad.net,

Message:
Please take a look.

Description:
Fetch MIRROR setting from /etc/default/lxc

Since we're passing custom userdata to the ubuntu-cloud lxc template, it
ends
up not setting the apt_mirror to the MIRROR setting. One could argue
that the
template should be fixed instead to always set the apt_mirror if it's
unset in
the custom userdata, but that's a separate discussion.

https://code.launchpad.net/~sidnei/juju-core/lxc-mirror/+merge/177737

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/12143043/

Affected files:
   A [revision details]
   M agent/agent.go
   M cloudinit/cloudinit_test.go
   M cloudinit/options.go
   M container/lxc/lxc.go
   M container/lxc/lxc_test.go
   M environs/cloudinit/cloudinit.go
   M environs/cloudinit/cloudinit_test.go
   M utils/apt.go
   M utils/apt_test.go

« Back to merge proposal