Code review comment for lp:~sibi-antony/stellarium/tui-enhancements

Revision history for this message
Sibi Antony (sibi-antony) wrote :

Alexwolf: Thanks for the review!

Shutdown - In my humble opinion, the shutdown has to be left to the user to choose, as it is a platform specific operation. Also the only people who will use the shutdown option will be planetarium folks, who doesn't have the luxury of a keyboard+console or GUI during presentations.

So with this implementation, we give an interface wherein user can supply a shutdown command/script. The privileges required for the operation is to be set by the user.
Besides, this is one reason we call it 'Admin->shutdown'. It requires the user to be admin! :)

I can document on the new option in stellarium wiki. If you think there are better ways of implementing this, please let me know.

« Back to merge proposal