Code review comment for lp:~shufgy/graphite/graphite

Revision history for this message
Michael Leinartas (mleinartas) wrote :

Sorry for letting this sit so long without comment.

I've delayed merging this primarily because I'm not sure whether this has broad enough use case. It think providing two separate metrics - one to display, one to test with - *might* make it a bit more broad, but it ruins what I think your use case is (correct me if I'm wrong): to use this as a conditional filter on a wildcard with many matches.

I'm going to think on this a bit more to see if I can come up with another more broad way to do a filter like this. If nothing comes to me, I'll just merge it - as Jeff said, it is harmless.

Anyone else who does think they'd use this, please +1

« Back to merge proposal