Merge lp:~shraddha-pandhe/cloud-init/debug-module into lp:~cloud-init-dev/cloud-init/trunk
Proposed by
Shraddha Pandhe
Status: | Merged |
---|---|
Merged at revision: | 898 |
Proposed branch: | lp:~shraddha-pandhe/cloud-init/debug-module |
Merge into: | lp:~cloud-init-dev/cloud-init/trunk |
Diff against target: |
80 lines (+76/-0) 1 file modified
cloudinit/config/cc_debug.py (+76/-0) |
To merge this branch: | bzr merge lp:~shraddha-pandhe/cloud-init/debug-module |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Joshua Harlow | Pending | ||
Review via email: mp+198119@code.launchpad.net |
To post a comment you must log in.
Neat!
I have a few nitpicks / suggestions:
* namespace the 'verbose' in config to appear under a 'debug'. Ie:
#cloud-config
debug:
verbose: True
* Allow me to set the target filename to write to:
#cloud-config
debug:
output: /tmp/debug.out
* possibly we could combine the 2 and just drop 'verbose'. Do nothing if 'output' isn't set, rather than if verbose is set to true.
* lastly, allow argument to set 'output'.
Ie, i'd like to be able to do:
cloud-init single --frequency=always --name=debug /tmp/debug.out
cat debug.out
make sense?
Thanks!