Code review comment for lp:~shiyee/update-notifier/fsck-at-reboot

On Thu, Nov 11, 2010 at 10:23:44AM -0000, Mads Chr. Olesen wrote:
> It seems to be broken if more than one ext partition is mounted:
> $ sudo bash -x update-motd-fsck-at-reboot --force
> ...
> + ext_partitions='/dev/sda2
> /dev/sda5'
> + OLD_IFS='
> '
> + IFS=' '
> + for part in '$ext_partitions'
> ++ dumpe2fs -h '/dev/sda2
> /dev/sda5'
> + dumpe2fs_out='Couldn'\''t find valid filesystem superblock.'
>
> Moving the IFS magic inside the loop seems to fix it.

Thanks! I commited another small change that removes the IFS entirely,
I think it works fine, but I would appreciate if you could double
check, I only have a single parition setup, this is why I didn't
detect this error.

Thanks,
 Michael