Code review comment for lp:~shevonar/widelands/nsis-cmake

Revision history for this message
Shevonar (shevonar) wrote :

I understand. :)
Getting rid of InnoSetup would even more unify the build process on Windows because only the CMake file needs to be changed not also the InnoSetup script. Since Tino is the only one who will use this feature regularly I really like to hear his opinion. I could imagine he would like a "WL_NOMUSIC" variable because his development builds usually don't have music. I will try to fix the bugs and make them easily changeable (even more variables in CMake) so everyones needs can be satisfied. I mark it as "Needs Fixing" myself ;)

review: Needs Fixing

« Back to merge proposal