Code review comment for lp:~shevonar/widelands/nsis-cmake
Revision history for this message
| Nasenbaer (nasenbaer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
I understand.
However I see things different. So here is my history lesson ;) :
Before Widelands' cmake implementation was ready for the public, we had 4 completely different build systems (scons for linux, xcode for mac, make for mingw win32 and msvc for win32). All of these needed maintenance. E.g. if a new source file was added, all of those 4 build systems required to add those files to a list somewhere in their files. The msvc Buildsystem was the first that was abonded and left alone in the wild ;). scons - also very often used didn't really work out that fine and had a lot of problems... Long speech short sense:
The bug you linked says in the description "We should try to replace InnoSetup with CPack NSIS functionality if that's is comfortable and also as complete and as intuitive as InnoSetup." and I agree, that we should do this, if the "ifs" are met.
There are not that much people that regulary build Widelands on windows + build a setup to provide for the public (am only aware of Tino), so taking care about 2 setup compiler scripts would be way to overpowered.