Code review comment for lp:~shevonar/widelands/nsis-cmake
Revision history for this message
| Shevonar (shevonar) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
The only advantage is that you can simply run "make package" and have a ready-to-run installer after a while. No extra step is necessary.
- The installer file size is about the same or slightly bigger
- I just tested the installation speed and InnoSetup is about more than 3 times slower! 8:40 min vs 2:25min. (However the creation of the NSIS installer takes about 3 or 4 times longer, but that shouldn't be a problem)
- NSIS and InnoSetup have nearly the same features. But NSIS is integrated into CPack and InnoSetup is not.
The changes are less changes than "bugs". I just didn't work on them yet. If there is need for these features there will be a way to realize them ;)