Merge lp:~shevonar/widelands/fix-cmake-codecheck into lp:widelands
Proposed by
Shevonar
Status: | Merged |
---|---|
Merged at revision: | 5987 |
Proposed branch: | lp:~shevonar/widelands/fix-cmake-codecheck |
Merge into: | lp:widelands |
Diff against target: |
41 lines (+16/-7) 2 files modified
src/CMakeLists.txt (+1/-1) src/CodeCheck.cmake (+15/-6) |
To merge this branch: | bzr merge lp:~shevonar/widelands/fix-cmake-codecheck |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
SirVer | Needs Fixing | ||
Review via email: mp+76662@code.launchpad.net |
Description of the change
This solved my codecheck problem :) For those who don't know what I mean: CodeCheck didn't report any issues on my Windows 7 64bit System with MinGW and MSYS. The problem was that a python script is not an executable file. So I changed the CodeCheck.cmake to call python and start the script instead of calling the script.
Hopefully it didn't break codecheck for anyone else, so please run a test before merging. If it does make problems I'll rework it to only use the changes on Windows.
Thanks for your efforts!
To post a comment you must log in.
Very nice catch! however, to make sure that the ways do not change on other systems (where the codecheck works) I would strongly suggest only running this on windows. Can you rework it?