Code review comment for lp:~shevonar/widelands/feature-random-tribe-and-AI

Revision history for this message
Nasenbaer (nasenbaer) wrote :

Cool! The changes look complete and generally good to me. Just checked every case I could think about and worked as it should.

There are still some codecheck issues inside and "random" should be translateable, but I'll take care of it.

Thinking about all the patches you lately provided, it would be a good idea, to give you write access to lp:widelands - just the codecheck thing is a bit ugly ;)

what kind of operating system do you use?
and how do you compile? I suggest using cmake and compiling in debug mode.

review: Approve

« Back to merge proposal