Code review comment for lp:~shevonar/widelands-website/django1.4

I have looked some more into the required migrations.

There's django-notification and changes in one table. I sorta have an approach for this, but it is rather hacky... Basically it would perform the necessary changes described in the issue linked to by Shevonar. Though since we don't define the notification models directly, from what I can see we import them in wiki/models.py, we don't really have an app which owns them. And South (the migration tool) is rather built for running migrations for an app, while we would have a migration for a table which comes from a dependency which we happen to have created. That doesn't sound all that ideal.

(An alternative solution could be to create a patched version of django-notification which includes the necessary migration and depend on that instead. Though at the moment it is not clear to me which point this would be executed when we do an upgrade. (Naturally we would switch back to a non-patched version later down the road)

Somewhat related question: Shevonar, why was the github repo where we pull in django-notification changed? I see the latest commit in the original repo we pointed to has replaced the code with a link to a different (third) repo, but I don't follow this project so I don't know what the differences are. Unless we need something specific, I'm somewhat tempted to simply replace the github url with version 0.2 and fetch it from pypi.

Regarding the timezone thingy, from what I read it would be possible to upgrade to 1.4 without touching the timezone info. We would need to add "USE_TZ = False" and it could continue to work as earlier. I do think we should do this migration, but it doesn't seem to be a prerequisite for upgrading to 1.4 so we might be able to delay it until we are at a more recent version.

SirVer: Btw, what sort of database do we use in production, which may affect how to approach how we deal with the timezones and potential conversion of the data?

According to https://docs.djangoproject.com/en/1.7/internals/release-process/, Django 1.4 will be supported until at least March 2015. That's not too long, but arguably better than no support. I think we need to push this more, because I fear we will run into problems unless we are able to upgrade it. :(