Code review comment for lp:~shawn111/checkbox/hexr-dkms

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I worked on this branch today and the results can be seen in the hexr-dkms branch of my git repository [1]

[1] https://code.launchpad.net/~zyga/checkbox/+git/checkbox/+ref/hexr-dkms

There are numerous changes that I've made. I think that docstrings and tests are badly missing in a few spots. The user interface could use a few changes too.

I ran the code on my machine with virtualbox module. I could use test data from systems that have the other useful types of module information (oem-something and patterned modaliases).

Lastly I think the way we collect and present information should change. Dicts are great but python objects are dicts too and they feel more suited for the job. This affects the get_dkmses and get_nondkmses functions.

I've left lots of XXX: notes in the tree, on stuff that I didn't finish fixing. Let's see what we can do about this.

review: Needs Fixing

« Back to merge proposal