Code review comment for lp:~shawn111/checkbox/hexr-dkms

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

16:25 < roadmr> zyga: got time for another quick look at https://code.launchpad.net/~shawn111/checkbox/hexr-dkms/+merge/257533 ? some things may still be missing :(
16:25 <@zyga> roadmr: yeah, looking
16:26 <@zyga> roadmr: oh, I did today I think
16:26 <@zyga> roadmr: let's see
16:28 <@zyga> roadmr: I did review it but not everything is done yet, I know shawnwang didn't know how to use lru_cache but we discussed that on IRC
16:28 <@zyga> roadmr: I'm waiting for another upload that will address all the manual caching
16:28 < roadmr> zyga: ok, not a problem, thanks!

« Back to merge proposal