Code review comment for lp:~shawn111/checkbox/hexr-dkms

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

To use flake8-docstrings just pip3 install --user flake8-docstrings
and run flake8 on the file you are working on.

The python3-debian module seems to contain the deb822 module which
seems to do the parsing for the Debian variant of RFC822. I would
prefer to use that over the email module as it probably handles
something that the email parser will misinterpret.

Thanks
ZK

On Tue, Apr 28, 2015 at 4:37 PM, Shawn Wang <email address hidden> wrote:
> @ZK,
>
> I still don't understand how to use flake8-docstrings to check.
> It gave me some Error but I have no idea how to fix, I will do it tomorrow.
>
> * I don't use python3-debian, because I just need the Modaliases information, rfc822 is good for this case
> * when will check_output() raise OSError? >> when dkms is not found
>
> --
> https://code.launchpad.net/~shawn111/checkbox/hexr-dkms/+merge/257533
> You are reviewing the proposed merge of lp:~shawn111/checkbox/hexr-dkms into lp:checkbox.

« Back to merge proposal