Code review comment for ~shaner/cloud-init:1781039

Revision history for this message
Shane Peters (shaner) wrote :

Thanks for the review Scott. I did notice the stricter checking and did consider leaving that bit behind, but like you said, it shouldn't cause any issues. I can still remove it if you'd like.

I tested the upgrade/reboot test as you suggested and things work as expected. Is there anything specific you'd like to see? Here's the test I ran and the subsequent cloud-init.log [0].

Also, I tested on lxd with some custom cloud-init config set in new profile which checked out okay as well. Logs for that are at [1].

Let me know if there's anything else.

Shane

[0] https://pastebin.ubuntu.com/p/rJ8pg9TvZ7/
[1] https://pastebin.ubuntu.com/p/FsdczQ2zzX/

« Back to merge proposal