Code review comment for ~shaner/charm-thruk-agent:master

Revision history for this message
Stuart Bishop (stub) wrote :

This charm needs to be reworked into charms.reactive, but that is beyond the scope of this MP. From my recollection of ServiceManager, this is the cleanest way to wait for the socket.

This all looks good. Per inline comment, I suspect you should be using 'waiting' instead of 'blocked' when the socket is not available. 'waiting' is when the charm is expected to resolve itself. 'blocked' means an action needs to be performed by somebody before things will resolve.

Confirm and/or change the pending status, and good for landing.

review: Approve

« Back to merge proposal