Code review comment for lp:~shanepatrickfagan/ubuntu-sso-client/nm-state-bug-fix

You should check the upstream history to see when the API change was made, and what the version number was at that time, and use that version number (or the next one after, as it may have only been bumped at release time).

And for comparison, as alecu said in IRC, you need to get the string split into a tuple of integers (and strings, if there are any non-numeric characters in the version like a/b/pre/etc...), check that the length of each tuple is >= 2, and then compare the tuples. Also need to ensure that the int() values are actually correct, and not just the ASCII numeric value (ie "0" becomes 0).