Ubuntu Single Sign On Client

Code review comment for lp:~shanepatrickfagan/ubuntu-sso-client/nm-state-bug-fix

  1. nm-state-bug-fix
  2. Merge into trunk
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

The code makes sense, though in order to get the Approve we need the following:

* unit tests for both branches of the newly added if
* self.NM_STATE_UNKNOWN should be defined for both versions of the protocol
* the protocol version number should not be a literal string but a constant

review: Needs Fixing

« Back to merge proposal