Merge lp:~sgaflv/workcraft/trunk-bug1379453 into lp:workcraft

[Stan]

[Danil Sokolov (danilovesky)]

It would be safer to use HashSet for referencing nodes instead of a counter.

review: Disapprove

=== modified file 'WorkcraftCore/src/org/workcraft/dom/DefaultMathNodeRemover.java'
--- WorkcraftCore/src/org/workcraft/dom/DefaultMathNodeRemover.java	2009-09-22 21:01:45 +0000
+++ WorkcraftCore/src/org/workcraft/dom/DefaultMathNodeRemover.java	2014-10-23 17:41:19 +0000
@@ -35,8 +35,12 @@
 	private void incRef (MathNode node) {
 		if (refCount.get(node) == null)
 			refCount.put(node, 1);
-		else
-			refCount.put(node, refCount.get(node)+1);
+		else {
+//			throw new RuntimeException("The element "+node.toString()+" was added before already!");
+			// TODO: why would we increase the counter more than once? which objects use that?
+			// TODO: with the counter, the reparenting in GroupImplementation still needs to be fixed not to cause double increase of the counter
+//			refCount.put(node, refCount.get(node)+1);
+		}
 	}
 
 	private void decRef (MathNode node) {