Code review comment for lp:~sforshee/apport/iwlwifi-fw-error
Revision history for this message
| Seth Forshee (sforshee) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Tue, Mar 25, 2014 at 05:58:53PM -0000, Martin Pitt wrote:
> Oh, and if iwlwifi_error_dump does the Title and DuplicateSignature fields, there is no need any more to hardcode this driver specific knowledge into the rather generic report.py.
Right. So I had only noticed the methods before and not the preferential
use of the fields. Those were the only reason I needed to add the new
ProblemType, so I think "KernelCrash" will probably work fine.
A udev rule is fine too, there's no reason it should take longer than 30
seconds. I'll make these updates.