Merge ~seyeongkim/postgresql-charm:fix_typo_max_val into postgresql-charm:master

Proposed by Seyeong Kim
Status: Merged
Approved by: Tom Haddon
Approved revision: 8f41e997b8cfd1c1f1042dd1167cf767774674c1
Merged at revision: 37d96332de864a2e8b3ab22d8c31a17d61b07bdc
Proposed branch: ~seyeongkim/postgresql-charm:fix_typo_max_val
Merge into: postgresql-charm:master
Diff against target: 13 lines (+1/-1)
1 file modified
reactive/postgresql/service.py (+1/-1)
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Canonical IS Reviewers Pending
Review via email: mp+413559@code.launchpad.net

Commit message

fix typo

Description of the change

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 37d96332de864a2e8b3ab22d8c31a17d61b07bdc

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reactive/postgresql/service.py b/reactive/postgresql/service.py
2index 99e07bd..09cf7b2 100644
3--- a/reactive/postgresql/service.py
4+++ b/reactive/postgresql/service.py
5@@ -810,7 +810,7 @@ def validate_postgresql_conf(conf):
6 if r.min_val and v < float(r.min_val):
7 raise ValueError("{} below minimum {}".format(v, r.min_val))
8 elif r.max_val and v > float(r.max_val):
9- raise ValueError("{} above maximum {}".format(v, r.maxvalue))
10+ raise ValueError("{} above maximum {}".format(v, r.max_val))
11
12 except ValueError as x:
13 raise InvalidPgConfSetting(k, x)

Subscribers

People subscribed via source and target branches

to all changes: