Merge ~seyeongkim/maas:lp1999827_3.2 into maas:3.2

[Seyeong Kim]

Fix reverse order ip address

When controller's nic has several ip and virtual ip,
SQL collect them reverse order. this fixes it.

(cherry picked from commit cfe8cf628f7189a84a98d74b3c079d744f1c1b5f)

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1999827_3.2 lp:~seyeongkim/maas/+git/maas into -b 3.2 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 04fec091679e814cb389cef88e249b912117711e

review: Approve

[MAAS Lander (maas-lander)]

UNABLE TO START LANDING

STATUS: MISSING COMMIT MESSAGE

diff --git a/src/maasserver/models/staticipaddress.py b/src/maasserver/models/staticipaddress.py
index 4144a9e..e7424a6 100644
--- a/src/maasserver/models/staticipaddress.py
+++ b/src/maasserver/models/staticipaddress.py
@@ -659,7 +659,8 @@ class StaticIPAddressManager(Manager):
                     ELSE staticip.alloc_type
                 END,
                 interface.id,
-                inet 'fc00::/7' >> ip /* ULA after non-ULA */
+                inet 'fc00::/7' >> ip /* ULA after non-ULA */,
+                staticip.id
             """
         iface_sql_query = (
             """
diff --git a/src/maasserver/models/tests/test_staticipaddress.py b/src/maasserver/models/tests/test_staticipaddress.py
index b202a32..347d5c8 100644
--- a/src/maasserver/models/tests/test_staticipaddress.py
+++ b/src/maasserver/models/tests/test_staticipaddress.py
@@ -446,6 +446,35 @@ class TestStaticIPAddressManagerMapping(MAASServerTestCase):
             },
         )
 
+    def test_get_hostname_ip_mapping_ip_order(self):
+        domain = Domain.objects.get_default_domain()
+        node = factory.make_Node()
+        interface1 = factory.make_Interface(node_config=node.current_config)
+        subnet = factory.make_Subnet()
+        staticip1 = factory.make_StaticIPAddress(
+            alloc_type=IPADDRESS_TYPE.STICKY,
+            ip=factory.pick_ip_in_Subnet(subnet),
+            subnet=subnet,
+            interface=interface1,
+        )
+        staticip2 = factory.make_StaticIPAddress(
+            alloc_type=IPADDRESS_TYPE.STICKY,
+            ip=factory.pick_ip_in_Subnet(subnet),
+            subnet=subnet,
+            interface=interface1,
+        )
+        self.assertEqual(
+            dict(StaticIPAddress.objects.get_hostname_ip_mapping(subnet)),
+            {
+                f"{node.hostname}.{domain.name}": HostnameIPMapping(
+                    node.system_id, 30, {staticip1.ip}, node.node_type
+                ),
+                f"{interface1.name}.{node.hostname}.{domain.name}": HostnameIPMapping(
+                    node.system_id, 30, {staticip2.ip}, node.node_type
+                ),
+            },
+        )
+
     def test_get_hostname_ip_mapping_returns_fqdn_and_other(self):
         hostname = factory.make_name("hostname")
         domainname = factory.make_name("domain")