Merge ~seyeongkim/maas:lp1929478 into maas:master

Proposed by Seyeong Kim
Status: Merged
Approved by: Alexsander de Souza
Approved revision: 67ddce79a0fd90c4d45798a1e325017aa3656e07
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~seyeongkim/maas:lp1929478
Merge into: maas:master
Diff against target: 13 lines (+1/-1)
1 file modified
src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py (+1/-1)
Reviewer Review Type Date Requested Status
Alexsander de Souza Approve
MAAS Lander Approve
Review via email: mp+425213@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

this is rough commit,
Please advise any. I wasn't able to test this but refered to https://discourse.maas.io/t/maas-failed-commissioning/4904

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1929478 lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/13038/console
COMMIT: 8b7025ebafc5e40203c2fc3c28809a9c75e19374

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1929478 lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 744c545cbbfe18dd464cdf6787353a8f60c9d267

review: Approve
Revision history for this message
Alexsander de Souza (alexsander-souza) wrote :

see comment inline

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1929478 lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 67ddce79a0fd90c4d45798a1e325017aa3656e07

review: Approve
Revision history for this message
Alexsander de Souza (alexsander-souza) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
2index a4c791f..4964f08 100755
3--- a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
4+++ b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
5@@ -242,7 +242,7 @@ class IPMIBase(BMCConfig):
6 )
7 raise
8 section = None
9- for line in proc.stdout.decode().splitlines():
10+ for line in proc.stdout.decode(errors="surrogateescape").splitlines():
11 line = line.split("#")[0].strip()
12 if not line:
13 continue

Subscribers

People subscribed via source and target branches