Juju Charms Collection
nova-compute package

Code review comment for lp:~seyeongkim/charms/trusty/nova-compute/lp1417891

  1. Trusty Tahr (14.04)
  2. lp1417891
  3. Merge into next
Revision history for this message
James Page (james-page) wrote :

Thanks for your proposal to resolve this problem.

I think that we should really fix this by setting the ulimit always for libvirt - so a configuration option is not really required.

We do this in other areas as well; I'd also like to see if we can get this into the Ubuntu packaging as well.

So please could you rework with the following changes:

1) Drop the configuration option

2) Set the ulimit via /etc/default/libvirt-bin

There's already a template for this - by doing it here, we ensure that this change is not lost when Ubuntu migrates to using systemd instead of upstream.

Thanks!

review: Needs Fixing

« Back to merge proposal