Merge lp:~seyeongkim/charms/trusty/neutron-api/lp1545886 into lp:~openstack-charmers-archive/charms/trusty/neutron-api/next

Proposed by Seyeong Kim
Status: Rejected
Rejected by: James Page
Proposed branch: lp:~seyeongkim/charms/trusty/neutron-api/lp1545886
Merge into: lp:~openstack-charmers-archive/charms/trusty/neutron-api/next
Diff against target: 84 lines (+14/-2)
5 files modified
config.yaml (+5/-0)
hooks/neutron_api_context.py (+4/-0)
templates/icehouse/ml2_conf.ini (+1/-1)
templates/kilo/ml2_conf.ini (+1/-1)
unit_tests/test_neutron_api_context.py (+3/-0)
To merge this branch: bzr merge lp:~seyeongkim/charms/trusty/neutron-api/lp1545886
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+286269@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #728 neutron-api-next for xtrusia mp286269
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/728/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #633 neutron-api-next for xtrusia mp286269
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/633/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #282 neutron-api-next for xtrusia mp286269
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15099691/
Build: http://10.245.162.36:8080/job/charm_amulet_test/282/

Unmerged revisions

176. By Seyeong Kim

add vni_ranges option

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2016-01-22 15:14:59 +0000
+++ config.yaml 2016-02-17 09:53:01 +0000
@@ -126,6 +126,11 @@
126 <physical_network> specifying physical_network names usable for VLAN126 <physical_network> specifying physical_network names usable for VLAN
127 provider and tenant networks, as well as ranges of VLAN tags on each127 provider and tenant networks, as well as ranges of VLAN tags on each
128 available for allocation to tenant networks.128 available for allocation to tenant networks.
129 vni-ranges:
130 type: string
131 default: "1001:2000"
132 description: |
133 Space-delimited list of <vxlan_min>:<vxlan_max> for VXLAN provider.
129 # Quota configuration settings134 # Quota configuration settings
130 quota-security-group:135 quota-security-group:
131 default: 10136 default: 10
132137
=== modified file 'hooks/neutron_api_context.py'
--- hooks/neutron_api_context.py 2016-01-22 15:14:59 +0000
+++ hooks/neutron_api_context.py 2016-02-17 09:53:01 +0000
@@ -228,6 +228,10 @@
228 if vlan_ranges:228 if vlan_ranges:
229 ctxt['vlan_ranges'] = ','.join(vlan_ranges.split())229 ctxt['vlan_ranges'] = ','.join(vlan_ranges.split())
230230
231 vni_ranges = config('vni-ranges')
232 if vni_ranges:
233 ctxt['vni_ranges'] = ','.join(vni_ranges.split())
234
231 ctxt['enable_ml2_port_security'] = config('enable-ml2-port-security')235 ctxt['enable_ml2_port_security'] = config('enable-ml2-port-security')
232236
233 return ctxt237 return ctxt
234238
=== modified file 'templates/icehouse/ml2_conf.ini'
--- templates/icehouse/ml2_conf.ini 2015-11-09 14:06:56 +0000
+++ templates/icehouse/ml2_conf.ini 2016-02-17 09:53:01 +0000
@@ -16,7 +16,7 @@
16tunnel_id_ranges = 1:100016tunnel_id_ranges = 1:1000
1717
18[ml2_type_vxlan]18[ml2_type_vxlan]
19vni_ranges = 1001:200019vni_ranges = {{ vni_ranges }}
2020
21[ml2_type_vlan]21[ml2_type_vlan]
22network_vlan_ranges = {{ vlan_ranges }}22network_vlan_ranges = {{ vlan_ranges }}
2323
=== modified file 'templates/kilo/ml2_conf.ini'
--- templates/kilo/ml2_conf.ini 2015-11-07 05:08:13 +0000
+++ templates/kilo/ml2_conf.ini 2016-02-17 09:53:01 +0000
@@ -20,7 +20,7 @@
20tunnel_id_ranges = 1:100020tunnel_id_ranges = 1:1000
2121
22[ml2_type_vxlan]22[ml2_type_vxlan]
23vni_ranges = 1001:200023vni_ranges = {{ vni_ranges }}
2424
25[ml2_type_vlan]25[ml2_type_vlan]
26network_vlan_ranges = {{ vlan_ranges }}26network_vlan_ranges = {{ vlan_ranges }}
2727
=== modified file 'unit_tests/test_neutron_api_context.py'
--- unit_tests/test_neutron_api_context.py 2016-01-22 15:14:59 +0000
+++ unit_tests/test_neutron_api_context.py 2016-02-17 09:53:01 +0000
@@ -319,6 +319,7 @@
319 'quota_subnet': 10,319 'quota_subnet': 10,
320 'quota_vip': 10,320 'quota_vip': 10,
321 'vlan_ranges': 'physnet1:1000:2000',321 'vlan_ranges': 'physnet1:1000:2000',
322 'vni_ranges': '1001:2000',
322 'enable_ml2_port_security': True323 'enable_ml2_port_security': True
323 }324 }
324 napi_ctxt = context.NeutronCCContext()325 napi_ctxt = context.NeutronCCContext()
@@ -354,6 +355,7 @@
354 'quota_subnet': 10,355 'quota_subnet': 10,
355 'quota_vip': 10,356 'quota_vip': 10,
356 'vlan_ranges': 'physnet1:1000:2000',357 'vlan_ranges': 'physnet1:1000:2000',
358 'vni_ranges': '1001:2000',
357 'network_providers': 'physnet2,physnet3',359 'network_providers': 'physnet2,physnet3',
358 'enable_ml2_port_security': True360 'enable_ml2_port_security': True
359 }361 }
@@ -395,6 +397,7 @@
395 'quota_subnet': 10,397 'quota_subnet': 10,
396 'quota_vip': 10,398 'quota_vip': 10,
397 'vlan_ranges': 'physnet1:1000:2000',399 'vlan_ranges': 'physnet1:1000:2000',
400 'vni_ranges': '1001:2000',
398 'enable_ml2_port_security': True401 'enable_ml2_port_security': True
399 }402 }
400 napi_ctxt = context.NeutronCCContext()403 napi_ctxt = context.NeutronCCContext()

Subscribers

People subscribed via source and target branches