Code review comment for lp:~seyeongkim/charms/trusty/ceph/lp1411652
Revision history for this message
| Chris MacNaughton (chris.macnaughton) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
According to the documentation:
"stop runs immediately before the end of the unit's destruction sequence. It should be used to ensure that the charm's software is not running, and will not start again on reboot.
This hook is called when a service removal is requested by the client. It should implement the following logic:
Stop the service
Remove any files/configuration created during the service lifecycle
Prepare any backup(s) of the service that are required for restore purposes."
I think then, that if re-adding the OSD works after this that we can say most of the logic should be handled. I'd like to see the stop hook also remove the ceph-mon-all service and ceph-osd-all service from upstart so that they don't run on reboot of the machine as well.