Code review comment for lp:~seyeongkim/charms/trusty/ceph/lp1411652

A charms 'stop' hook is called as the instance of the charm is destroyed on
a unit - so I think its appropriate to remove the OSD from the cluster at
this point, as the next step taken by juju will be to destroy the machine
its running on; dropping the OSD from the cluster configuration here LGTM.

On Mon, Jan 11, 2016 at 4:38 AM, Seyeong Kim <email address hidden>
wrote:

> Thanks for your review.
>
> As you can see the bug report, mon, osd ( + crushmap, auth ) are still
> remains after unit added & removed several times.
>
> You mean this needs kind of "shutdown" hook instead of stop hook?
> This seems not which i can do..
>
> Thanks.
>
> > I'm very nervous about unilaterally removing monitors and OSDs on the
> stop
> > hook. I think that we may want to make this stop hook actions instead of
> a
> > hook that can be called implicitly.
> >
> > What is the goal with this change? To remove nodes from a production Ceph
> > cluster or maybe to remove OSDs for maintenance?
> --
>
> https://code.launchpad.net/~xtrusia/charms/trusty/ceph/lp1411652/+merge/281732
> Your team OpenStack Charmers is requested to review the proposed merge of
> lp:~xtrusia/charms/trusty/ceph/lp1411652 into
> lp:~openstack-charmers/charms/trusty/ceph/next.
>