Juju Charms Collection
ceph package

Code review comment for lp:~seyeongkim/charms/trusty/ceph/lp1411652

  1. Trusty Tahr (14.04)
  2. lp1411652
  3. Merge into next
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

Thanks for your review.

As you can see the bug report, mon, osd ( + crushmap, auth ) are still remains after unit added & removed several times.

You mean this needs kind of "shutdown" hook instead of stop hook?
This seems not which i can do..

Thanks.

> I'm very nervous about unilaterally removing monitors and OSDs on the stop
> hook. I think that we may want to make this stop hook actions instead of a
> hook that can be called implicitly.
>
> What is the goal with this change? To remove nodes from a production Ceph
> cluster or maybe to remove OSDs for maintenance?

« Back to merge proposal