Merge ~seyeongkim/charm-graylog:increase_timeout_for_request into charm-graylog:master

Proposed by Seyeong Kim
Status: Merged
Approved by: Erhan Sunar
Approved revision: 43e4cb8232fdea674cfaa38ecfa324f78a295da3
Merged at revision: c9843b7aee427aacd795f1be13317b338a0ea4a9
Proposed branch: ~seyeongkim/charm-graylog:increase_timeout_for_request
Merge into: charm-graylog:master
Diff against target: 64 lines (+4/-17)
2 files modified
src/lib/charms/layer/graylog/api.py (+1/-1)
src/reactive/graylog.py (+3/-16)
Reviewer Review Type Date Requested Status
Ramesh Sattaru (community) Approve
Erhan Sunar (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Review via email: mp+436739@code.launchpad.net

Commit message

increasing timeout for request

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Erhan Sunar (esunar) wrote :

There is a linting error(it blocks running of functional tests) can you fix?

black --check --exclude '/(\.eggs|\.git|\.tox|\.venv|\.build|dist|charmhelpers|mod)/' .

review: Needs Fixing
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Erhan Sunar (esunar) :
review: Approve
Revision history for this message
Ramesh Sattaru (rameshcan) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision c9843b7aee427aacd795f1be13317b338a0ea4a9

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/lib/charms/layer/graylog/api.py b/src/lib/charms/layer/graylog/api.py
2index 7445fa6..8640650 100644
3--- a/src/lib/charms/layer/graylog/api.py
4+++ b/src/lib/charms/layer/graylog/api.py
5@@ -59,7 +59,7 @@ class GraylogApi:
6 self.token = None
7 self.input_types = None
8 self.req_retries = 4
9- self.req_timeout = 3
10+ self.req_timeout = 10
11 self.verify = verify
12
13 @retry(
14diff --git a/src/reactive/graylog.py b/src/reactive/graylog.py
15index 640e262..5e81f22 100644
16--- a/src/reactive/graylog.py
17+++ b/src/reactive/graylog.py
18@@ -598,11 +598,8 @@ def graylog_remove_filebeat_input():
19 inputs = g.log_input_get()
20
21 if inputs is not None:
22-
23 for inp in inputs:
24-
25 if inp["title"].lower() == "juju_beats_input":
26-
27 g.log_input_remove(inp["id"])
28 hookenv.log(
29 "Removed beats input: {} ({})".format(inp["title"], inp["id"])
30@@ -933,10 +930,7 @@ def setup_gelf_tcp_input(gelf):
31 "title": "juju_gelf_tcp_input",
32 "type": type,
33 "global": "true",
34- "configuration": {
35- "bind_address": "0.0.0.0",
36- "port": gelf_port,
37- },
38+ "configuration": {"bind_address": "0.0.0.0", "port": gelf_port},
39 }
40
41 proto = "TCP"
42@@ -1107,11 +1101,7 @@ def validate_jvm_heap_size(str_size, total_mem=0):
43 raise ValueError("jvm heap size must be a multiple of 1024")
44 else:
45 # only allow these units, and scale is 1024
46- units = {
47- "k": 1024,
48- "m": 1024 * 1024,
49- "g": 1024 * 1024 * 1024,
50- }
51+ units = {"k": 1024, "m": 1024 * 1024, "g": 1024 * 1024 * 1024}
52 for unit, scale in units.items():
53 if str_size.endswith(unit):
54 str_size = str_size[:-1] # rm unit
55@@ -1517,10 +1507,7 @@ def _maybe_install_ca_certificates_hook():
56
57 def _maybe_configure_graylog_jvm_keystore():
58 templating.render(
59- "default-graylog-server",
60- SERVER_DEFAULT_CONF_FILE,
61- context={},
62- perms=0o644,
63+ "default-graylog-server", SERVER_DEFAULT_CONF_FILE, context={}, perms=0o644
64 )
65
66

Subscribers

People subscribed via source and target branches

to all changes: