Merge lp:~seth-arnold/ubuntu-archive-tools/release-in-bug-text into lp:ubuntu-archive-tools

[Seth Arnold]

Add the release to the bug text when a package is released from -proposed
to -updates. I re-flowed the text around the changed line lengths.

[Colin Watson (cjwatson)]

The problem with this is that the "Update Released" message is only be added once, so, for a bug targeted to (e.g.) both precise and quantal, this will cause there to be a message saying it's been released to precise-updates and none saying it's been released to quantal-updates, or vice versa, whichever happens to be released first. I think this will result in confusion.

Perhaps we need a separate message for each series that's released. I'd like Brian to comment on this.

review: Needs Fixing

[Colin Watson (cjwatson)]

(obviously I meant "is only added once" in that last comment)

[Brian Murray (brian-murray)]

In my opinion the intent of the message is to indicate that the Ubuntu SRU team is no longer monitoring the bug report and to tell people the proper way to open bug reports about problems encountered with the SRU. The part about -updates may even be unnecessary. Subsequently, I don't think adding in the release provides any additional information. The comment(s) from the Launchpad Janitor indicate in which specific release the bug was fixed.

[Seth Arnold (seth-arnold)]

> The problem with this is that the "Update Released" message is only be added
> once, so, for a bug targeted to (e.g.) both precise and quantal, this will
> cause there to be a message saying it's been released to precise-updates and
> none saying it's been released to quantal-updates, or vice versa, whichever
> happens to be released first. I think this will result in confusion.

Darn, I thought that patch went too easily. Yes, I agree that if this message
is only going to be pasted onto a bug once, this is not the correct way to do it.

> Perhaps we need a separate message for each series that's released. I'd like
> Brian to comment on this.

This was my intent, though I obviously missed some of the changes necessary.
SRU bugs with more than one series is complicated enough, I had hoped changing
this text to be more precise about what specifically was fixed would help remove
some of the confusion.

Thanks for the review.

[Steve Langasek (vorlon)]

The ubuntu-archive-tools repository is being migrated from bzr to git, which means this MP will no longer be mergeable. If you wish to proceed with this MP please resubmit against the git repository.

Unmerged revisions

773. By Seth Arnold on 2013-09-06

Add release to the -updates bug message

=== modified file 'sru-release'
--- sru-release	2013-08-20 18:57:23 +0000
+++ sru-release	2013-09-06 00:28:29 +0000
@@ -67,7 +67,7 @@
     return bugs
 
 
-def update_sru_bug(bug):
+def update_sru_bug(bug, release):
     '''Unsubscribe SRU team and comment on bug re: how to report regressions'''
     m_subjects = [m.subject for m in bug.messages]
     if 'Update Released' in m_subjects:
@@ -77,12 +77,13 @@
     bug.unsubscribe(person=sru_team)
     text = ("The verification of this Stable Release Update has completed "
             "successfully and the package has now been released to "
-            "-updates.  Subsequently, the Ubuntu Stable Release Updates "
-            "Team is being unsubscribed and will not receive messages "
-            "about this bug report.  In the event that you encounter "
-            "a regression using the package from -updates please report "
-            "a new bug using ubuntu-bug and tag the bug report "
-            "regression-update so we can easily find any regresssions.")
+            "%s-updates.  Subsequently, the Ubuntu Stable Release "
+            "Updates Team is being unsubscribed and will not receive "
+            "messages about this bug report.  In the event that you "
+            "encounter a regression using the package from %s-updates "
+            "please report a new bug using ubuntu-bug and tag the "
+            "bug report regression-update so we can easily find any "
+            "regresssions.") % (release, release)
     bug.newMessage(subject="Update Released", content=text)
     bug.lp_save()
 
@@ -185,7 +186,7 @@
                 sru_bugs = match_srubugs(options, versions['changesfile'])
                 for sru_bug in sru_bugs:
                     if 'verification-needed' not in sru_bug.tags:
-                        update_sru_bug(sru_bug)
+                        update_sru_bug(sru_bug, release)
 
         # -proposed -> -security
         if options.security: