Merge ~sespiros/ubuntu-security-tools/+git/ubuntu-security-tools:coverity-snap-update-command into ubuntu-security-tools:master

[Spyros Seimenis]

I copied the install command to a new update command which disregards the existence of the symlink, deletes it and reinstalls a new coverity version. I also changed the snap's version to not follow the coverity versions since it doesn't make much sense. We may also want to delete the previous version's untarred files (not in this commit).

With this, if you already have the coverity snap installed, updating coverity locally should work like:

1) Download new coverity binary (+ license)
2) Run

coverity-ubuntu-security.update cov-analysis...tar.gz license...dat

Unmerged commits

a84fcd6... by Spyros Seimenis on 2023-10-23

snaps/coverity: add update functionality

This adds the update command, useful for when the coverity binaries
get updated.

Since this is an utility package and doesn't actually include coverity,
it doesn't make sense for its version to follow coverity versions as in
new coverity versions don't necessarily need an updated coverity snap.

diff --git a/snaps/coverity-ubuntu-security/files/bin/update b/snaps/coverity-ubuntu-security/files/bin/update
new file mode 100755
index 0000000..e387cc2
--- /dev/null
+++ b/snaps/coverity-ubuntu-security/files/bin/update
@@ -0,0 +1,60 @@
+#!/bin/sh
+set -e
+
+install_symlink="cov-analysis-current"
+topdir="$SNAP_USER_COMMON/$install_symlink"
+bindir="$topdir/bin"
+
+if [ -z "$SNAP_USER_COMMON" ]; then
+    echo "SNAP_USER_COMMON not set! Aborting"
+    exit 1
+fi
+
+if [ ! -e "$1" ]; then
+    echo "Please specify the path to a cov-analysis tarball"
+    exit 1
+fi
+cova="$1"
+if echo "$cova" | grep -vq '/' ; then
+    cova="$(pwd)/$cova"
+fi
+
+if [ ! -e "$2" ]; then
+    echo "Please specify a valid path to the license file"
+    exit 1
+fi
+lic="$2"
+if echo "$lic" | grep -vq '/' ; then
+    lic="$(pwd)/$lic"
+fi
+
+if [ ! -d "$SNAP_USER_COMMON" ]; then
+    mkdir -p "$SNAP_USER_COMMON"
+fi
+
+if [ -d "$bindir" ]; then
+    inst=$(readlink "$SNAP_USER_COMMON/$install_symlink")
+    echo "Previous install detected at '$inst'. Deleting..."
+    rm $SNAP_USER_COMMON/$install_symlink
+else
+    echo "Previous coverity install not found. Use command \"install\" to do a fresh installation."
+    exit 1
+fi
+
+cd "$SNAP_USER_COMMON"
+echo "Untarring '$cova' to $SNAP_USER_COMMON..."
+tar -zxf "$cova"
+
+echo "Creating $install_symlink symlink in $SNAP_USER_COMMON..."
+bn=$(basename "$cova" .tar.gz)
+ln -s "$bn" "$install_symlink"
+if [ ! -d "$bindir" ]; then
+    echo "Could not find '$bindir'. Not installing license file"
+    exit 1
+fi
+
+echo "Copying '$lic' to $bindir..."
+cp "$lic" "$bindir"
+
+echo "Update completed."
+echo
diff --git a/snaps/coverity-ubuntu-security/snapcraft.yaml b/snaps/coverity-ubuntu-security/snapcraft.yaml
index c2d5cda..d0ff8ef 100644
--- a/snaps/coverity-ubuntu-security/snapcraft.yaml
+++ b/snaps/coverity-ubuntu-security/snapcraft.yaml
@@ -1,5 +1,5 @@
 name: coverity-ubuntu-security
-version: "2023.03-64"
+version: "0.0.1"
 summary: Coverity packaging for running as a snap
 description: |
  Unpack cov-analysis-linux64-YYYY.MM.tar.gz to $SNAP_USER_COMMON with a symlink
@@ -19,6 +19,10 @@ apps:
     command: bin/install
     plugs:
     - home
+  update:
+    command: bin/update
+    plugs:
+    - home
   refresh-auth-key:
     command: bin/refresh-auth-key
     plugs: