ubuntu-security-tools

Merge ~sespiros/ubuntu-security-tools/+git/ubuntu-security-tools:uaudit-fix-install-options into ubuntu-security-tools:master

  1. Git
  2. lp:~sespiros/ubuntu-security-tools/+git/ubuntu-security-tools
  3. uaudit-fix-install-options
  4. Merge into master
Proposed by Spyros Seimenis
Status: Merged
Merged at revision: 4ccf49fac01c52d2b3df1cf13703dfabea7317c7
Proposed branch: ~sespiros/ubuntu-security-tools/+git/ubuntu-security-tools:uaudit-fix-install-options
Merge into: ubuntu-security-tools:master
Diff against target: 18 lines (+5/-2)
1 file modified
audits/uaudit (+5/-2)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Review via email: mp+442823@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM - thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/audits/uaudit b/audits/uaudit
2index 09cf3df..9fa9db7 100755
3--- a/audits/uaudit
4+++ b/audits/uaudit
5@@ -72,8 +72,11 @@ class StaticAnalysisTool(object):
6 self._install_options = install_options
7
8 def install_cmd(self) -> list:
9- return ["sudo", "apt" if self._source == StaticAnalysisToolSource.DEB else "snap",
10- "install", self._install_options, self.name]
11+ cmd = ["sudo", "apt" if self._source == StaticAnalysisToolSource.DEB else "snap",
12+ "install", self.name]
13+ if self._install_options != "":
14+ cmd.append(self._install_options)
15+ return cmd
16
17 def exec_cmd(self, format) -> list:
18 if format == "txt":

Subscribers

People subscribed via source and target branches