Ubuntu CVE Tracker

Code review comment for ~sespiros/ubuntu-cve-tracker/+git/ubuntu-cve-tracker:source-map-fix

  1. Git
  2. lp:~sespiros/ubuntu-cve-tracker/+git/ubuntu-cve-tracker
  3. source-map-fix
  4. Merge into master
Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM - that is much nicer than my suggestion.

The only problem is I think python's assignment expression syntax was only introduced in 3.8 - but we still have to support python 3.6 on people.canonical.com:

ssh people.canonical.com python3 -c "if a := 1: print(a)"
bash: -c: line 0: syntax error near unexpected token `('
bash: -c: line 0: `python3 -c if a := 1: print(a)'

So this will need a slight refactoring unfortunately.

review: Needs Fixing

« Back to merge proposal