Code review comment for lp:~sergiusens/ubuntu-clock-app/reboot-packaging

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Thu, Aug 7, 2014 at 7:34 PM, Nekhelesh Ramananthan <<email address hidden>
> wrote:

> Review: Needs Information
>
> - change qml imports
>
> What do you mean by this? Does this mean "import Alarm.Settings 1.0" in
> the qml code will change to something else?
>

Since Daniel mentioned a better location for the libs I appended a Clock.
to the path, so most likely it means you need to prepend this.

>
> - I've changed the path for a couple of things to use common subpaths in
> most cases, it may break some of your scenarios.
>
> Not exactly sure what you mean by scenarios.
>

In other words, needs testing in qt creator

I don't have a full environment with me to test all this; I'll look into
this in the AM

Is this landing into the archives btw?

« Back to merge proposal