Code review comment for lp:~sergiusens/touch-preview-images/phablet-build-scripts

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

8 +package_extract_file("ubuntu_deploy.sh", "/tmp/ubuntu_deploy.sh");
9 +set_perm(0, 0, 0777, "/tmp/ubuntu_deploy.sh");

Do we really have /tmp/ access at recovery? Never tested, downloading the tarball to test.

55 +cat > ${WORKDIR}/ubuntu_deploy.sh << 'EOF'
56 +#!/sbin/sh

Any reason for it not to be a separated script? If separated, also make sure to add a header with copyright and such.

61 +phablet_home_bak=/data/phablet_home
+network_settings_bak=/data/nm_connections

I'd prefer to use a common directory for backups, like /data/ubuntu_bak or similar, so we know where to find the files in case of a failure when flashing the image.

Rest looks fine, creating an image to test it.

review: Needs Information

« Back to merge proposal