Merge lp:~sergiusens/snapweb/sortResults into lp:~snappy-dev/snapweb/trunk

Proposed by Sergio Schvezov
Status: Merged
Approved by: John Lenton
Approved revision: 116
Merged at revision: 116
Proposed branch: lp:~sergiusens/snapweb/sortResults
Merge into: lp:~snappy-dev/snapweb/trunk
Diff against target: 64 lines (+3/-5)
2 files modified
snappy/converge.go (+3/-0)
snappy/converge_test.go (+0/-5)
To merge this branch: bzr merge lp:~sergiusens/snapweb/sortResults
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+258375@code.launchpad.net

Commit message

Return an ordered list of packages.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'snappy/converge.go'
--- snappy/converge.go 2015-05-05 22:49:07 +0000
+++ snappy/converge.go 2015-05-06 12:51:43 +0000
@@ -18,6 +18,7 @@
18package snappy18package snappy
1919
20import (20import (
21 "sort"
21 "strconv"22 "strconv"
22 "strings"23 "strings"
2324
@@ -153,6 +154,8 @@
153 snapPkgs = append(snapPkgs, *v)154 snapPkgs = append(snapPkgs, *v)
154 }155 }
155156
157 sort.Sort(snapPkgsByName(snapPkgs))
158
156 return snapPkgs159 return snapPkgs
157}160}
158161
159162
=== modified file 'snappy/converge_test.go'
--- snappy/converge_test.go 2015-05-05 22:49:07 +0000
+++ snappy/converge_test.go 2015-05-06 12:51:43 +0000
@@ -21,7 +21,6 @@
21 "io/ioutil"21 "io/ioutil"
22 "os"22 "os"
23 "path/filepath"23 "path/filepath"
24 "sort"
2524
26 . "gopkg.in/check.v1"25 . "gopkg.in/check.v1"
27 "launchpad.net/snappy/snappy"26 "launchpad.net/snappy/snappy"
@@ -134,7 +133,6 @@
134 }133 }
135134
136 snaps := mergeSnaps(installed, nil, true)135 snaps := mergeSnaps(installed, nil, true)
137 sort.Sort(snapPkgsByName(snaps))
138136
139 c.Assert(snaps, HasLen, 3)137 c.Assert(snaps, HasLen, 3)
140 c.Assert(snaps[0].Name, Equals, "app1.canonical")138 c.Assert(snaps[0].Name, Equals, "app1.canonical")
@@ -165,7 +163,6 @@
165163
166 // Only installed164 // Only installed
167 snaps := mergeSnaps(installed, remotes, true)165 snaps := mergeSnaps(installed, remotes, true)
168 sort.Sort(snapPkgsByName(snaps))
169166
170 c.Assert(snaps, HasLen, 3)167 c.Assert(snaps, HasLen, 3)
171 c.Check(snaps[0].Name, Equals, "app1.canonical")168 c.Check(snaps[0].Name, Equals, "app1.canonical")
@@ -188,7 +185,6 @@
188185
189 // Installed and remotes186 // Installed and remotes
190 snaps = mergeSnaps(installed, remotes, false)187 snaps = mergeSnaps(installed, remotes, false)
191 sort.Sort(snapPkgsByName(snaps))
192188
193 c.Assert(snaps, HasLen, 4)189 c.Assert(snaps, HasLen, 4)
194 c.Check(snaps[0].Name, Equals, "app1.canonical")190 c.Check(snaps[0].Name, Equals, "app1.canonical")
@@ -233,7 +229,6 @@
233229
234 // Installed and remotes230 // Installed and remotes
235 snaps := mergeSnaps(installed, remotes, false)231 snaps := mergeSnaps(installed, remotes, false)
236 sort.Sort(snapPkgsByName(snaps))
237232
238 c.Assert(snaps, HasLen, 5)233 c.Assert(snaps, HasLen, 5)
239 c.Check(snaps[0].Name, Equals, "app1.canonical")234 c.Check(snaps[0].Name, Equals, "app1.canonical")

Subscribers

People subscribed via source and target branches