Merge lp:~sergiusens/snapcraft/setuptools into lp:~snappy-dev/snapcraft/core

[Sergio Schvezov]

setuptools for python 2 projects

Something like this MP is needed for this to work:
https://github.com/sergiusens/galileo

I don't think this is the final solution, but I am not sure how to proceed either.

[Leo Arias (elopio)]

<elopio> sergiusens: can't you specify the python-setuptools dependency in the yaml of your package?
<elopio> there are other setup packages, so not all will require setuptools.

review: Needs Information

[Michael Vogt (mvo)]

I think we should merge the python2_project changes if that unblocks you. The python-setuptools could come via the snapcraft.yaml as well.

review: Approve

[Björn Tillenius (bjornt)]

> <elopio> sergiusens: can't you specify the python-setuptools dependency in the
> yaml of your package?
> <elopio> there are other setup packages, so not all will require setuptools.

How would you specify python-setuptools in the yaml?

Anyway, I think setuptools is so widespread, that it makes sense to support it by
default. It will lower the entry bar a lot.

Unmerged revisions

=== modified file 'snapcraft/plugins/python2.py'
--- snapcraft/plugins/python2.py	2015-08-05 15:39:18 +0000
+++ snapcraft/plugins/python2.py	2015-08-06 02:15:41 +0000
@@ -24,7 +24,7 @@
         super().__init__(name, options)
 
         class UbuntuOptions:
-            packages = ["python-dev"]
+            packages = ["python-dev", "python-setuptools"]
         self.ubuntu = ubuntu.UbuntuPlugin(name, UbuntuOptions())
 
     # note that we don't need to set PYTHONHOME here,

=== modified file 'snapcraft/plugins/python2_project.py'
--- snapcraft/plugins/python2_project.py	2015-08-03 18:21:58 +0000
+++ snapcraft/plugins/python2_project.py	2015-08-06 02:15:41 +0000
@@ -14,6 +14,8 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+import os
+
 import snapcraft
 
 
@@ -26,6 +28,11 @@
         return self.handle_source_options()
 
     def build(self):
+        env = os.environ.copy()
+        env['PYTHONPATH'] = "{}/usr/lib/python2.7/dist-packages/".format(self.installdir)
+        # Install will fail if PYTHONPATH does not exist
+        os.makedirs(env['PYTHONPATH'])
         return self.run(
             ["python2", "setup.py", "install", "--install-layout=deb",
-             "--prefix={}/usr".format(self.installdir)])
+             "--prefix={}/usr".format(self.installdir)],
+            env=env)