Merge lp:~sergiusens/snapcraft/for-ted into lp:~ted/snapcraft/aws-iot

Proposed by Sergio Schvezov
Status: Merged
Merged at revision: 253
Proposed branch: lp:~sergiusens/snapcraft/for-ted
Merge into: lp:~ted/snapcraft/aws-iot
Diff against target: 41 lines (+4/-9)
1 file modified
snapcraft/tests/test_cmds.py (+4/-9)
To merge this branch: bzr merge lp:~sergiusens/snapcraft/for-ted
Reviewer Review Type Date Requested Status
Ted Gould Pending
Review via email: mp+276078@code.launchpad.net
To post a comment you must log in.
lp:~sergiusens/snapcraft/for-ted updated
253. By Sergio Schvezov

Update unit tests for collision detection

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'snapcraft/tests/test_cmds.py'
2--- snapcraft/tests/test_cmds.py 2015-10-28 22:11:26 +0000
3+++ snapcraft/tests/test_cmds.py 2015-10-29 02:43:11 +0000
4@@ -25,6 +25,7 @@
5 from snapcraft import (
6 cmds,
7 common,
8+ lifecycle,
9 tests
10 )
11
12@@ -39,16 +40,12 @@
13 self.addCleanup(tmpdirObject.cleanup)
14 tmpdir = tmpdirObject.name
15
16- part1 = mock.Mock()
17- part1.name = 'part1'
18- part1.code.options.stage = ['*']
19+ part1 = lifecycle.load_plugin('part1', 'jdk', {'source': '.'})
20 part1.installdir = tmpdir + '/install1'
21 os.makedirs(part1.installdir + '/a')
22 open(part1.installdir + '/a/1', mode='w').close()
23
24- part2 = mock.Mock()
25- part2.name = 'part2'
26- part2.code.options.stage = ['*']
27+ part2 = lifecycle.load_plugin('part2', 'jdk', {'source': '.'})
28 part2.installdir = tmpdir + '/install2'
29 os.makedirs(part2.installdir + '/a')
30 with open(part2.installdir + '/1', mode='w') as f:
31@@ -57,9 +54,7 @@
32 with open(part2.installdir + '/a/2', mode='w') as f:
33 f.write('a/2')
34
35- part3 = mock.Mock()
36- part3.name = 'part3'
37- part3.code.options.stage = ['*']
38+ part3 = lifecycle.load_plugin('part3', 'jdk', {'source': '.'})
39 part3.installdir = tmpdir + '/install3'
40 os.makedirs(part3.installdir + '/a')
41 os.makedirs(part3.installdir + '/b')

Subscribers

People subscribed via source and target branches

to all changes: