Code review comment for lp:~sergiusens/reminders-app/cmake_common
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> This breaks lots of stuff. And only partially renames reminders-app to
> reminders.
Aside from applicationName, where else is it missing?
> Why don't you use the existing .desktop filename?
>
> I don't see any advantage in generating all that stuff with cmake.
The advantage is that we don't have hard coded strings all over the place