Code review comment for lp:~sergiusens/reminders-app/cmake_common

Revision history for this message
Michael Zanetti (mzanetti) wrote :

This breaks lots of stuff. And only partially renames reminders-app to reminders.

Why don't you use the existing .desktop filename?

I don't see any advantage in generating all that stuff with cmake.

review: Disapprove

« Back to merge proposal