Code review comment for lp:~sergiusens/phablet-tools/server_options

Revision history for this message
Andy Doan (doanac) wrote :

> I'm not a big fan of the download function logic:
> + if uri.startswith('http://10.97.0.26'):
>
> but adding some "--curl" option and then passing it around everyone is a bit
> cumbersome also.

I'm starting to think we should make this optional. For example, we have an upcoming lab move and we probably don't want to tie phablet-tools to our current lab configuration. I think there are two alternatives you could try:

1) add a new "--curl" option that says to use curl.

2) add a new "--download-cmd" option that allows you to specify what command to download with. The default command would then be: "wget -c {uri} -O {path}".

« Back to merge proposal